Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exceptions inside Query.snapshots() and more now have a stack trace that correctly points to the invocation of the throwing method #9639

Merged
merged 2 commits into from Oct 6, 2022

Conversation

rrousselGit
Copy link
Contributor

Description

Due to StreamController.onListen shenanigans, exceptions within its callback have an incorrect stacktrace.
To fix this, we can keep a reference on the caller stacktrace, and on error, report the error with that stacktrace instead.

While we're at this, this PR also changes a few EventChanne.receiveBroadcastStream that did not implement a "handleError", so platform exceptions were not converted to FirebaseExceptions.

Related Issues

fixes #6743

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…ace that correctly points to the invocation of the throwing method
@rrousselGit rrousselGit marked this pull request as draft September 29, 2022 19:06
@rrousselGit rrousselGit marked this pull request as ready for review October 3, 2022 09:15
Copy link
Contributor

@Lyokone Lyokone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I had no idea Stacktrace.current existed :) Thanks a lot

@russellwheatley russellwheatley merged commit 2f7adcb into master Oct 6, 2022
@russellwheatley russellwheatley deleted the @rrousselGit/stackTrace branch October 6, 2022 07:57
@MrAlek
Copy link

MrAlek commented Oct 6, 2022

Amazing, thanks @rrousselGit!

@bernaferrari
Copy link
Contributor

Oh, finally!! Thanks a lot!!!

@firebase firebase locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants