Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(messaging): add support for exporting delivery metrics to BigQuery #9636

Merged
merged 13 commits into from Oct 6, 2022

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Sep 29, 2022

Description

In order to support deliveryMetricsExportedToBigQueryEnabled on the Web, I had to set up a service worker with a bundler
The reasons:

  • The v9 compat version does not includes the needed deliveryMetricsExportedToBigQueryEnabled method
  • By setting the service worker type to module, the Firebase Messaging service worker fails because it does not support es modules

Related Issues

closes #8538

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone changed the title feat(messaging): automatic export to bigquery feat(messaging): message delivery data export to BigQuery Oct 4, 2022
@Lyokone Lyokone marked this pull request as ready for review October 4, 2022 08:05
@Lyokone Lyokone marked this pull request as draft October 4, 2022 09:03
@Lyokone Lyokone marked this pull request as ready for review October 5, 2022 09:16
@Lyokone Lyokone changed the title feat(messaging): message delivery data export to BigQuery feat(messaging): add support for exporting delivery metrics to BigQuery Oct 5, 2022
@Lyokone Lyokone merged commit 170b99b into master Oct 6, 2022
@Lyokone Lyokone deleted the feat/exportbigquery branch October 6, 2022 13:06
@firebase firebase locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add steps to enable delivery report exports to big query.
4 participants