Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore, web): explicitly set null value on Firestore data object property value #9599

Merged
merged 4 commits into from Sep 28, 2022

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Sep 22, 2022

Description

A very bizarre exception occurring on Firestore web in release mode.

DocumentReference users = FirebaseFirestore.instance.collection('flutter-tests').doc('1');

final List<String?> media = List<String?>.filled(1, null);
//This will error even though `media.first` is a `null` object 
await users.set({'greatField2': media.first});
DocumentReference users = FirebaseFirestore.instance.collection('flutter-tests').doc('1');

//This will not error 
await users.set({'greatField2': null});

Explicity setting null fixes the issue. This is a hot fix, it appears to be an issue with how it is being evaluated by dart2js.

I've created a bug report on the Dart repo here.
I've created an issue which is tracked on our project board here.

Related Issues

fixes #9567

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix(firestore, web): allow null value on Firestore data object fix(firestore, web): explicitly set null value on Firestore data object property value Sep 22, 2022
@russellwheatley russellwheatley merged commit e61b603 into master Sep 28, 2022
@russellwheatley russellwheatley deleted the @russell/firestore-9567 branch September 28, 2022 09:57
@firebase firebase locked and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants