Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firestore): serverTimestampBehaviour #9590

Merged
merged 8 commits into from Dec 20, 2022
Merged

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Sep 22, 2022

Description

Implementing the ServerTimestampBehavior according to #9859 and internal discussion on API.
Support for query, namedQuery and document get.

We save the timestamp behavior for each request in a map and recover it when sending the information back to the user.

Related Issues

closes #9859

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone marked this pull request as ready for review December 20, 2022 09:08
@Lyokone Lyokone merged commit c25bd2f into master Dec 20, 2022
@Lyokone Lyokone deleted the feat/serverTimestamp branch December 20, 2022 13:43
@firebase firebase locked and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cloud_firetore] ServerTimestampBehavior implementation details
3 participants