Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump Firebase iOS SDK to 9.6.0 #9531

Merged
merged 3 commits into from Sep 27, 2022
Merged

Conversation

russellwheatley
Copy link
Member

Description

see title.

Related Issues

closes #8811

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note @russellwheatley that this contains a fix for all people using 9.5.0 that stops firestore from eating 10% as soon as it is used, until app is closed.

I have not seen any problems personally from a work app I have released with 9.6.0 on the react-native-firebase side

@mikehardy
Copy link
Contributor

The macOS failure looks unrelated:

Specs satisfying the `FirebaseFirestore (from `[https://github.com/invertase/firestore-ios-sdk-frameworks.git`](https://github.com/invertase/firestore-ios-sdk-frameworks.git%60), tag `9.6.0`)` dependency were found, but they required a higher minimum deployment target.

Here is the thing with that: the cocoapods integration of Firestore is using the pre-compiled framework which is based off the zip distribution, which has a minimum target of iOS 11 and macOS 10.13 -- see here invertase/firestore-ios-sdk-frameworks#56 (comment)

Those are slightly higher than the cocoapods (not zip-based!) requirements for firestore.

So you either need to de-integrate the pre-compiled version and use the "normal" cocoapods integration for firestore, or you need to update the minimum target for iOS/macOS to get that CI check to pass

Note that as Paul B says, next version of firebase-ios-sdk will use the new minimums already in place for zip distribution, even on the cocoapods integration, so my suggested course for CI would be to go ahead and bump the minimum target since it will be necessary soon anyway, but that's a policy decision, and there may be good reasons not to.

@russellwheatley russellwheatley merged commit 2138f4a into master Sep 27, 2022
@russellwheatley russellwheatley deleted the @russell/ios-9.6.0 branch September 27, 2022 13:44
@firebase firebase locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release & Debug version of the app asking keychain permissions
6 participants