New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump Firebase iOS SDK to 9.6.0
#9531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note @russellwheatley that this contains a fix for all people using 9.5.0 that stops firestore from eating 10% as soon as it is used, until app is closed.
I have not seen any problems personally from a work app I have released with 9.6.0 on the react-native-firebase side
The macOS failure looks unrelated:
Here is the thing with that: the cocoapods integration of Firestore is using the pre-compiled framework which is based off the zip distribution, which has a minimum target of iOS 11 and macOS 10.13 -- see here invertase/firestore-ios-sdk-frameworks#56 (comment) Those are slightly higher than the cocoapods (not zip-based!) requirements for firestore. So you either need to de-integrate the pre-compiled version and use the "normal" cocoapods integration for firestore, or you need to update the minimum target for iOS/macOS to get that CI check to pass Note that as Paul B says, next version of firebase-ios-sdk will use the new minimums already in place for zip distribution, even on the cocoapods integration, so my suggested course for CI would be to go ahead and bump the minimum target since it will be necessary soon anyway, but that's a policy decision, and there may be good reasons not to. |
Description
see title.
Related Issues
closes #8811
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?