Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump Firebase iOS SDK to 9.5.0 #9492

Merged
merged 2 commits into from Sep 8, 2022
Merged

feat: Bump Firebase iOS SDK to 9.5.0 #9492

merged 2 commits into from Sep 8, 2022

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Sep 8, 2022

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@@ -1,5 +1,5 @@
# Uncomment this line to define a global platform for your project
# platform :ios, '9.0'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Flutter 3.3 compatibility

@Salakar
Copy link
Member

Salakar commented Sep 8, 2022

@russellwheatley do you remember if there was a somewhere else it needed updating also, was it in the docs? 🤔

@russellwheatley
Copy link
Member

We previously had to update the docs but now that has been removed from the current documentation so this is fine 👍

@Lyokone Lyokone merged commit d246ba2 into master Sep 8, 2022
@Lyokone Lyokone deleted the feat/ios-9.5.0 branch September 8, 2022 12:33
@nilsreichardt
Copy link
Contributor

@russellwheatley The iOS SDK version is mentioned in the Firestore docs: https://firebase.google.com/docs/firestore/quickstart#set_up_your_development_environment

@russellwheatley
Copy link
Member

russellwheatley commented Sep 9, 2022

@nilsreichardt Thanks for letting me know! It's not in the FlutterFire repo I'm afraid.

@kevinthecheung Do you mind updating this part of the documentation so it reads like the below, please:

  pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => '9.5.0'

Link: https://firebase.google.com/docs/firestore/quickstart#dart
Screenshot 2022-09-09 at 07 54 13

@nilsreichardt
Copy link
Contributor

Yes, unfortunately, the Cloud Firestore docs are not open source :(

@firebase firebase locked and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants