Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_messaging, android): ensure only messaging permission request is processed #9486

Merged
merged 3 commits into from Sep 8, 2022

Conversation

russellwheatley
Copy link
Member

Description

See title.

Related Issues

fixes #9429
fixes #9430

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley marked this pull request as ready for review September 7, 2022 10:03
@russellwheatley russellwheatley changed the title fix(firebase_messaging): ensure only messaging permission request is processed fix(firebase_messaging, android): ensure only messaging permission request is processed Sep 7, 2022
@russellwheatley russellwheatley added type: bug Something isn't working plugin: messaging platform: android Issues / PRs which are specifically for Android. labels Sep 7, 2022
@russellwheatley russellwheatley merged commit 5b31e71 into master Sep 8, 2022
@russellwheatley russellwheatley deleted the @russell/messaging-9430 branch September 8, 2022 11:35
@firebase firebase locked and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: android Issues / PRs which are specifically for Android. plugin: messaging type: bug Something isn't working
Projects
None yet
5 participants