Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_app_check): provide androidDebugProvider boolean for android debug provider & update app check example app #9412

Merged
merged 20 commits into from Sep 28, 2022

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Aug 24, 2022

Description

Blocks App check debug documentation which will be merged once this PR is merged.

Related Issues

closes #6551

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added platform: android Issues / PRs which are specifically for Android. plugin: app_check labels Aug 24, 2022
# Conflicts:
#	packages/firebase_app_check/firebase_app_check/android/src/main/java/io/flutter/plugins/firebase/appcheck/FlutterFirebaseAppCheckPlugin.java
@russellwheatley russellwheatley marked this pull request as ready for review August 24, 2022 12:53
@russellwheatley russellwheatley changed the title chore(firebase_app_check): Update example app and android configuration for debug testing feat(firebase_app_check): "androidDebugProvider" API for activate() for testing purposes & update app check example app Sep 12, 2022
@russellwheatley russellwheatley changed the title feat(firebase_app_check): "androidDebugProvider" API for activate() for testing purposes & update app check example app feat(firebase_app_check): provide androidDebugProvider boolean for android testing & update app check example app Sep 12, 2022
@russellwheatley russellwheatley changed the title feat(firebase_app_check): provide androidDebugProvider boolean for android testing & update app check example app feat(firebase_app_check): provide androidDebugProvider boolean for android debug provider & update app check example app Sep 12, 2022
@russellwheatley
Copy link
Member Author

We probably should look to create an option for users to choose between the two different android providers as well (Safety Net and Play Integrity) which this PR attempted to implement

@russellwheatley russellwheatley merged commit f1f2674 into master Sep 28, 2022
@russellwheatley russellwheatley deleted the @russell/app-check-6551 branch September 28, 2022 10:44
@firebase firebase locked and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: android Issues / PRs which are specifically for Android. plugin: app_check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [FIREBASE_APP_CHECK] App Check considers all requests to be malicious
3 participants