Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, android): fix crash on Android where detaching from engine was not properly resetting the Pigeon handler #9218

Merged
merged 1 commit into from Jul 26, 2022

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Jul 25, 2022

Description

See title

Related Issues

Fixes #9210

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…was not properly resetting the Pigeon handler
@alectogeek
Copy link

Any updates here?
It's a kinda urgent fix :D

@Lyokone Lyokone merged commit 96d35df into master Jul 26, 2022
@Lyokone Lyokone deleted the fix/9210 branch July 26, 2022 17:02
@timobaehr
Copy link

What is the version for the fix?

@alectogeek
Copy link

What is the version for the fix?

It is not published yet. The will include it to 3.5.2, I guess

@timobaehr
Copy link

Does anyone know the right version mix to downgrade? 3.4.2 saying for Android build:

Unexpected element  (URI:"", lokal:"base-extension").
../../../.pub-cache/hosted/pub.dartlang.org/firebase_auth-3.4.2/lib/src/recaptcha_verifier.dart:57:27: Error: Required named parameter 'auth' must be provided.
      _factory.delegateFor(

In my pubspec.yaml: firebase_auth: '<=3.4.2'. Same for 3.4.1 and 3.3.20.

@bhumkong
Copy link

@timobaehr you can pin these versions:

dependencies:
  firebase_auth: 3.4.2
dependency_overrides:
  firebase_auth_platform_interface: 6.3.2

@skobak
Copy link

skobak commented Jul 29, 2022

Seems like the firebase_auth: ^3.6.1 is fixing that issue for me. (3.6.0 contain the fix itself)
will keep testing...

@nilsreichardt
Copy link
Contributor

What is the version for the fix?

The fix is published in version 3.6.0. You can see the changelog of this version here: https://pub.dev/packages/firebase_auth/changelog#360

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [FirebaseAuth] NullPointerException on GeneratedAndroidFirebaseAuth
8 participants