Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, ios): Apple Sign In on a secondary app doesnt sign in the correct Firebase Auth instance #10018

Merged
merged 1 commit into from Dec 1, 2022

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Nov 29, 2022

Description

We weren't using the correct FirebaseAuth instance when Sign In With Apple, which could cause issues when running secondary apps.

Related Issues

closes #10001

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone changed the title fix(auth, ios): Apple Sign In on a secondary app fix(auth, ios): Apple Sign In on a secondary app doesnt sign in the correct Firebase Auth instance Nov 29, 2022
@Lyokone Lyokone marked this pull request as ready for review November 29, 2022 15:00
@Lyokone Lyokone merged commit f746d5d into master Dec 1, 2022
@Lyokone Lyokone deleted the fix/10001 branch December 1, 2022 15:37
@firebase firebase locked and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_auth] Apple authentication fails on iOS in secondary Firebase apps
3 participants