Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui_oauth_google, android): fix an issue with Google Sign In where the clientId was passed on Android #10017

Merged
merged 1 commit into from Nov 29, 2022

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Nov 29, 2022

Description

As described in the google_sign_in documentation, we shouldn't pass the clientId on Android: https://pub.dev/packages/google_sign_in#android-integration

Related Issues

#10005

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone changed the title fix(ui, android): fix an issue with Google Sign In where the clientId was passed on Android fix(firebase_ui_oauth_google, android): fix an issue with Google Sign In where the clientId was passed on Android Nov 29, 2022
@Lyokone Lyokone changed the title fix(firebase_ui_oauth_google, android): fix an issue with Google Sign In where the clientId was passed on Android fix(ui_oauth_google, android): fix an issue with Google Sign In where the clientId was passed on Android Nov 29, 2022
@lesnitsky
Copy link
Member

Closed #9971

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants