Skip to content

Xinxinxin #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 12, 2020
Merged

Xinxinxin #762

merged 18 commits into from
Oct 12, 2020

Conversation

xil222
Copy link
Contributor

@xil222 xil222 commented Oct 9, 2020

Removal of implementation & tests for accountchooser.com shut down.

xil222 added 14 commits June 23, 2020 12:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@xil222 xil222 requested a review from bojeil-google October 9, 2020 19:47
soy/elements.soy Outdated
@@ -387,7 +378,7 @@
{template .password}
{@param? current: bool} /** Whether to show "Current password" or "Password" label. */
<div class="firebaseui-textfield mdl-textfield mdl-js-textfield mdl-textfield--floating-label">
<label class="mdl-textfield__label firebaseui-label" for="ui-sign-in-password-input">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revert this change. It was added by external contributor

Copy link
Contributor

@bojeil-google bojeil-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the fixes.

@bojeil-google bojeil-google merged commit a9c367d into master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants