From f19187dc0328f890ee2b0f5ca3909c70d9b6f9a2 Mon Sep 17 00:00:00 2001 From: Bryan Kendall Date: Mon, 6 Apr 2020 09:30:17 -0700 Subject: [PATCH 1/2] quiet require-atomic-updates --- .eslintrc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.eslintrc.js b/.eslintrc.js index e6e98788c09..3f1b53fdc50 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -19,6 +19,7 @@ module.exports = { "prettier/prettier": "error", "valid-jsdoc": "off", // This is deprecated but included in recommended configs. "require-jsdoc": "off", // This rule is deprecated and superseded by jsdoc/require-jsdoc. + "require-atomic-updates": "off", // This rule is so noisey and isn't useful: https://github.com/eslint/eslint/issues/11899 "no-prototype-builtins": "warn", // TODO(bkendall): remove, allow to error. "no-restricted-globals": ["error", "name", "length"], "no-useless-escape": "warn", // TODO(bkendall): remove, allow to error. @@ -52,7 +53,6 @@ module.exports = { "no-constant-condition": "warn", // TODO(bkendall): remove, allow to error. "no-fallthrough": "warn", // TODO(bkendall): remove, allow to error. "no-unused-vars": "warn", // TODO(bkendall): remove, allow to error. - "require-atomic-updates": "warn", // TODO(bkendall): remove, allow to error. }, }, { From 5519715eb36215c75e71a44ea9a7d6071447e339 Mon Sep 17 00:00:00 2001 From: Bryan Kendall Date: Mon, 6 Apr 2020 09:33:31 -0700 Subject: [PATCH 2/2] I cannot spell --- .eslintrc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.eslintrc.js b/.eslintrc.js index 3f1b53fdc50..86a3cd53003 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -19,7 +19,7 @@ module.exports = { "prettier/prettier": "error", "valid-jsdoc": "off", // This is deprecated but included in recommended configs. "require-jsdoc": "off", // This rule is deprecated and superseded by jsdoc/require-jsdoc. - "require-atomic-updates": "off", // This rule is so noisey and isn't useful: https://github.com/eslint/eslint/issues/11899 + "require-atomic-updates": "off", // This rule is so noisy and isn't useful: https://github.com/eslint/eslint/issues/11899 "no-prototype-builtins": "warn", // TODO(bkendall): remove, allow to error. "no-restricted-globals": ["error", "name", "length"], "no-useless-escape": "warn", // TODO(bkendall): remove, allow to error.