You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"hosting": {
// ...
// Directs all requests from the page `/helloworld` to trigger and run a `helloworld` container
"rewrites": [ {
"source": "/helloworld",
"run": {
"serviceId": "helloworld", // "service name" (from when you deployed the container image)
"pinTag": true
}
} ]
}
Make a new Firebase hosting Next.js project, for example with firebase init hosting
Add the aforementioned minInstances setting to your hosting configuration.
Deploy
[REQUIRED] Expected behavior
Successful deploys with no errors. Alternatively, a warning stating that pinTag was not set if that's what happens. Maybe remove pinTag: true from wherever it's set or allow setting pinTag: false in the frameworks configuration.
[REQUIRED] Actual behavior
The deploy script prints the following error:
Error: Function ssrhelloworld has minInstances set and is in a rewrite pinTags=true. These features are not currently compatible with each other..
However, when viewing the Function and associated Cloud Run, minInstances seem to be set and the deploy is successful. A tag is not associated with the revision. Here's a screenshot from the page of the associated Cloud Run:
The text was updated successfully, but these errors were encountered:
I learnt some more about what happens. While a new revision is created, traffic actually doesn't route there as far as I can tell. I found out by my deleting the previous revision (which did not have minInstances) which immediately broke our site.
Anyway; would be nice to be able to deploy a site that does not suffer from cold starts.
[REQUIRED] Environment info
firebase-tools: 13.7.1
Platform: Ubuntu
[REQUIRED] Test case
Adding this configuration in
firebase.json
to you Firebase hosted Next.js project causes some inconveniences:I think it adds, hidden from the developer, something like this to the deployment configuration (https://firebase.google.com/docs/hosting/full-config#rewrite-cloud-run-container) :
Related items: #6484 and #6684
[REQUIRED] Steps to reproduce
firebase init hosting
minInstances
setting to your hosting configuration.[REQUIRED] Expected behavior
Successful deploys with no errors. Alternatively, a warning stating that pinTag was not set if that's what happens. Maybe remove
pinTag: true
from wherever it's set or allow settingpinTag: false
in the frameworks configuration.[REQUIRED] Actual behavior
The deploy script prints the following error:
Error: Function ssrhelloworld has minInstances set and is in a rewrite pinTags=true. These features are not currently compatible with each other.
.However, when viewing the Function and associated Cloud Run,
minInstances
seem to be set and the deploy is successful. A tag is not associated with the revision. Here's a screenshot from the page of the associated Cloud Run:The text was updated successfully, but these errors were encountered: