Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase deployment uploads .secret.local #7017

Closed
nomagick opened this issue Apr 18, 2024 · 2 comments · Fixed by #7018
Closed

Firebase deployment uploads .secret.local #7017

nomagick opened this issue Apr 18, 2024 · 2 comments · Fixed by #7018

Comments

@nomagick
Copy link

Firebase deployment uploads .secret.local .

When the application is breached somehow, the file may be leaked unexpectedly.
(it happened)

So could you at least add this particular file to default ignore?
Or just simply load the .gitignore and respect that?

Even this file is not leaked to a third-party, it does not mean the user agrees to share it with Google.

Can't believe I'm reporting this to Google in 2024.

@nomagick
Copy link
Author

Or just ignore *.local as it says local ?

@aalej
Copy link
Contributor

aalej commented Apr 18, 2024

Hey @nomagick, thanks for the feedback. Sorry to hear you’ve encountered this issue. I do agree that this is something that we could improve on so that secret values are not leaked.

Being an open source community, feedback coming from our fellow developers helps us polish our product better, and we appreciate that you brought this to our attention.

Let me try to bring this up to our engineering team to discuss what can be improved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants