firebase deploy returns an exit code == 0 even if a function failed to be deployed

[Philmod]

[REQUIRED] Environment info

Version: 13.7.1

OS: Ubuntu

[REQUIRED] Test case

Deployment with a failing function update.

[REQUIRED] Steps to reproduce

firebase deploy returns an exit code of 0 even if there is a failure like:

# firebase deploy
⚠  functions: failed to update function projects/philmod-godds/locations/us-central1/functions/authentication-delete
Failed to update function projects/philmod-godds/locations/us-central1/functions/authentication-delete

# echo $?
0

[REQUIRED] Expected behavior

Returns an exit code != 0 if it failed.

[REQUIRED] Actual behavior

Return an exit code == 0 even in case of a failure.

[google-oss-bot]

This issue does not seem to follow the issue template. Make sure you provide all the required information.

[Philmod]

This issue does not seem to follow the issue template. Make sure you provide all the required information.

fixed

[aalej]

Hey @Philmod, thanks for filing this issue. I’m currently unable to reproduce the behavior you mentioned. I tried firebase deploy using the ff:

functions/index.js

const functions = require("firebase-functions/v1");
const logger = require("firebase-functions/logger");

exports.authDelete = functions.auth.user().onDelete((user) => {
 logger.log("---- user1 ----");
 logger.debug(user);
});

functions/.env - setting PATH causes the function update to fail

PATH="some/path"

And an error is being raised, which returns a non-zero exit code(2).

i  functions: updating Node.js 18 (1st Gen) function authDelete(us-central1)...
⚠  functions: failed to update function projects/PROJECT_ID/locations/us-central1/functions/authDelete
Failed to update function projects/PROJECT_ID/locations/us-central1/functions/authDelete

Functions deploy had errors with the following functions:
        authDelete(us-central1)
i  functions: cleaning up build files...

Error: There was an error deploying functions

Having trouble? Try again or contact support with contents of firebase-debug.log
USER$ echo $?
2

To get a better understanding of what’s causing the failed update to not raise an error, could you provide code snippets of the functions you’re trying to deploy, and additional details on your project’s setup such as env variables being set?

[Philmod]

Hey @aalej,

I'm using Google Cloud Build to deploy the firebase functions, using this docker image.
I wonder if that's the reason the exit code is swallowed?

I don't think the function in itself has anything special. No specific env variables set either.