Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue templates #5475

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Update issue templates #5475

merged 2 commits into from
Jan 31, 2023

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Jan 31, 2023

Switch Bug report template to use label 'Type: Bug' and adds 'Type: Feature Request' to feature request template.

Switch Bug report template to use label 'Type: Bug' and adds 'Type: Feature Request' to feature request template.
@@ -1,8 +1,8 @@
---
name: ⚠️ Bug report
name: "⚠️ Bug report"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it necessary to put this in quotes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, not sure it is necessary. I edited this via the Github UI and it automatically added those in. I can remove if you'd like, but I don't see any issue with including them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just my pet peeve. I don't understand why it defaults to adding quotes around strings that don't need to be quoted. w/e haha

@@ -1,8 +1,8 @@
---
name: 💡 Feature request
name: "\U0001F4A1 Feature request"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I figure quotes are required here for the unicode character?)

@joehan joehan requested a review from bkendall January 31, 2023 19:41
@bkendall bkendall enabled auto-merge (squash) January 31, 2023 20:18
@bkendall bkendall merged commit 020c96b into master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants