Randomize port used for function discovery to reduce race conditions. #5444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When spinning up admin server for function discovery, we rely on
portfinder.getPort()
function to find an open port for the admin server to listen.portfinder starts from a base port number (e.g. 9005), trying incrementally larger number until an open port is found. This mechanism can lead to race condition when multiple processes look for an open port from the same base port number.
This PR adds a small jitter to the base port number when calling
portfinder
to reduce likeliness of a race condition.Fixes #5418.