Refactor how node binary is retrieved for functions/extensions.

[taeold]

Today, Functions Emulator make strong assumption that all functions target node runtime and pass around references like nodeBinary, nodeMajorVersion, etc.

This PR refactors the logic to abstract away node into bin and runtime. The logic for choosing the appropriate bin for the function is lifted to RuntimeDelegate, same piece of code that holds together other nodejs runtime specific logic.

The refactored required small changes to the extensions emulator - looping in @joehan to see if he has any objections.

[taeold]

Current dependencies on/for this PR:

• master
  • PR Remove go discovery module for CF3 #5419
    • PR Refactor how node binary is retrieved for functions/extensions. #5422 👈
      • PR Add python support for Functions Emulator. #5423
        • PR Enforce function timeout at worker level. #5464
          • PR Add option to initialize python functions. #5465
            • PR Fix emulator support for cloudevent to better conform to production specification. #5466
        • PR Add integration test for python support for functions emulator. #5462

This comment was auto-generated by Graphite.

[codecov-commenter]

Codecov Report

Base: 56.34% // Head: 56.30% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (e7d25e2) compared to base (9be77ff).
Patch coverage: 13.84% of modified lines in pull request are covered.

Additional details and impacted files

@@                      Coverage Diff                       @@
##           Remove_go_discovery_module    #5422      +/-   ##
==============================================================
- Coverage                       56.34%   56.30%   -0.04%     
==============================================================
  Files                             313      313              
  Lines                           21198    21208      +10     
  Branches                         4325     4327       +2     
==============================================================
- Hits                            11943    11942       -1     
- Misses                           8218     8228      +10     
- Partials                         1037     1038       +1     

Impacted Files	Coverage Δ
src/deploy/functions/runtimes/index.ts	54.16% <ø> (ø)
src/emulator/controller.ts	12.70% <0.00%> (-0.24%)	⬇️
src/emulator/extensionsEmulator.ts	35.25% <ø> (ø)
src/emulator/functionsEmulator.ts	7.27% <3.84%> (+0.33%)	⬆️
src/deploy/functions/runtimes/node/index.ts	19.14% <4.34%> (-5.51%)	⬇️
src/extensions/emulator/specHelper.ts	46.15% <46.15%> (-3.85%)	⬇️
src/extensions/emulator/optionsHelper.ts	42.47% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[TheIronDev]

Can you write tests for these new functions too?

[joehan]

This change makes a lot of sense to me and mostly looks good. However, I get a little worried whenever we start messing with paths in the emulator.

Could you test the following cases:

• Emulate an extension, confirm it executes
• Emulate an extension, confirm it uses the right version of node (even when different from the system version)

[taeold]

@joehan

Could you test the following cases:
Emulate an extension, confirm it executes

Doesn't the extensions emulator test exercise this scenario? Was hoping that it did!

[joehan]

@taeold Totally forgot we had that test running on CI - it definitely does cover that case