Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying the same function twice does not skip subsequent function deploy #5354

Closed
mercury2269 opened this issue Dec 21, 2022 · 0 comments · Fixed by #5355
Closed

Deploying the same function twice does not skip subsequent function deploy #5354

mercury2269 opened this issue Dec 21, 2022 · 0 comments · Fixed by #5355

Comments

@mercury2269
Copy link
Contributor

mercury2269 commented Dec 21, 2022

[REQUIRED] Environment info

firebase-tools: 11.19.0

Platform: macOS

[REQUIRED] Test case

setup multiple configuration values in

firebase functions:config:set akey.avalue=1
firebase functions:config:set akey.bvalue=1
firebase functions:config:set akey.cvalue=1
firebase functions:config:set akey.dvalue=1
firebase functions:config:set bkey.avalue=1
firebase functions:config:set bkey.bvalue=1
firebase functions:config:set bkey.cvalue=1
firebase functions:config:set bkey.dvalue=1

[REQUIRED] Steps to reproduce

  1. Build your test function
  2. Deploy your test function
  3. Deploy your test function again

[REQUIRED] Expected behavior

The second function deploy with the same exact code base, configuration and secrets should be skipped

[REQUIRED] Actual behavior

The function is deployed again.

Discovered issue

Runtime configuration hash is not sorted/deterministic and produces a different hash every time given there are enough configuration objects.

@mercury2269 mercury2269 changed the title Deploying the same function twice does not skip subsequent deploy Deploying the same function twice does not skip subsequent function deploy Dec 21, 2022
@taeold taeold linked a pull request Dec 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants