When deploying Next.js utilize esbuild via NPX #5336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdaniels
commented
Dec 14, 2022
jamesdaniels
commented
Dec 14, 2022
jamesdaniels
commented
Dec 14, 2022
jamesdaniels
commented
Dec 14, 2022
Codecov ReportBase: 56.40% // Head: 56.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5336 +/- ##
==========================================
+ Coverage 56.40% 56.42% +0.02%
==========================================
Files 315 315
Lines 21142 21145 +3
Branches 4285 4286 +1
==========================================
+ Hits 11926 11932 +6
+ Misses 8191 8188 -3
Partials 1025 1025
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jamesdaniels
commented
Dec 14, 2022
jamesdaniels
commented
Dec 14, 2022
jamesdaniels
commented
Dec 14, 2022
jamesdaniels
changed the title
TheIronDev
reviewed
Dec 15, 2022
TheIronDev
approved these changes
Dec 15, 2022
|
I successfully deployed a Next.js app with middleware in a M1 Pro using this PR's build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch
firebase deployNext.js to shell out tonpx esbuildrather than having esbuild as a (pinned) dependency in firebase-tools. Fixes #5268