Add in user envs to emulator #5330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colerogers
force-pushed
the
colerogers.fix-user-env-emulator
branch
from
fa061f8
to
13144c3
Compare
Berlioz
approved these changes
Dec 13, 2022
| @@ -1 +1,2 @@ | |||
| - Add sharp NPM module to Cloud Functions when using Next.js Image Optimization | |||
| - Adds user-defined env vars into the functions emulator (#5330). | |||
There was a problem hiding this comment.
the most trivial conceivable nit--this sentence ends with a period but the one above it doesn't?
There was a problem hiding this comment.
🤣 I'm a big fan of our changelog's ending in periods, so I added one to the first entry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5219