-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuxt support #5321
Nuxt support #5321
Conversation
Codecov ReportBase: 56.30% // Head: 56.26% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5321 +/- ##
==========================================
- Coverage 56.30% 56.26% -0.05%
==========================================
Files 315 317 +2
Lines 21348 21402 +54
Branches 4353 4365 +12
==========================================
+ Hits 12020 12041 +21
- Misses 8287 8312 +25
- Partials 1041 1049 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
* refactor the Nuxt 2 build workflow to accommodate all the ssr/target combinations * eliminated some eslint warnings * abstracted some common methods outside the main nuxt file * started using some interfaces * started testing scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM better than what we have. Add changelog and can you fix Austin's email in a force-push?
Description
This PR handles basic Nuxt 2 and Next 3 support.
Scenarios Tested
Covers basic Nuxt 3 with limited configuration.
Nuxt 2 has a couple more use cases, but the following should be handled:
ssr: false
ssr: true
target: 'server'
target: 'static'
Sample Commands
Deploying Nuxt 2 and 3 codebase via
firebase emulators:start
.