Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for CF3v2 functions in the Extensions emulator. #5306

Merged
merged 2 commits into from Dec 6, 2022

Conversation

pavelgj
Copy link
Collaborator

@pavelgj pavelgj commented Dec 6, 2022

No description provided.

@pavelgj pavelgj requested a review from joehan December 6, 2022 19:39
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Base: 56.28% // Head: 56.35% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (801295e) compared to base (1ebb9f8).
Patch coverage: 72.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5306      +/-   ##
==========================================
+ Coverage   56.28%   56.35%   +0.07%     
==========================================
  Files         309      310       +1     
  Lines       20830    20907      +77     
  Branches     4229     4250      +21     
==========================================
+ Hits        11725    11783      +58     
- Misses       8093     8100       +7     
- Partials     1012     1024      +12     
Impacted Files Coverage Δ
src/extensions/billingMigrationHelper.ts 72.72% <42.85%> (-5.06%) ⬇️
src/extensions/emulator/specHelper.ts 48.21% <44.44%> (+1.27%) ⬆️
src/emulator/eventarcEmulatorUtils.ts 62.06% <62.06%> (ø)
src/extensions/emulator/triggerHelper.ts 84.09% <82.05%> (-9.66%) ⬇️
src/deploy/extensions/planner.ts 51.28% <100.00%> (+0.63%) ⬆️
src/emulator/eventarcEmulator.ts 10.22% <100.00%> (+1.03%) ⬆️
src/emulator/extensions/validation.ts 86.11% <100.00%> (+0.39%) ⬆️
src/extensions/displayExtensionInfo.ts 80.95% <100.00%> (+0.62%) ⬆️
src/extensions/extensionsHelper.ts 62.57% <100.00%> (+0.11%) ⬆️
src/extensions/types.ts 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small improvments but mostly LGTM. If you're feeling inspired, consider adding an extension with v2 functions in it to the integration test as well: https://github.com/firebase/firebase-tools/tree/master/scripts/extensions-emulator-tests

src/extensions/billingMigrationHelper.ts Outdated Show resolved Hide resolved
src/extensions/emulator/triggerHelper.ts Show resolved Hide resolved
@pavelgj pavelgj merged commit ff9497e into master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants