Improve handling of bad versions during ext:install #5305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 56.28% // Head: 56.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5305 +/- ##
==========================================
+ Coverage 56.28% 56.30% +0.01%
==========================================
Files 310 310
Lines 20860 20863 +3
Branches 4236 4236
==========================================
+ Hits 11742 11747 +5
+ Misses 8101 8099 -2
Partials 1017 1017
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
elvisun
reviewed
Dec 6, 2022
src/extensions/extensionsHelper.ts
Outdated
| @@ -834,13 +834,17 @@ export async function diagnoseAndFixProject(options: any): Promise<void> { | |||
| * 2. Infer "latest" as the version if not provided | |||
| */ | |||
| export async function canonicalizeRefInput(extensionName: string): Promise<string> { | |||
There was a problem hiding this comment.
the word "name" has lost its value (at least to me...) consider naming this input and the variable inferredRef
elvisun
reviewed
Dec 6, 2022
| extensionVersion("0.1.0"), | ||
| extensionVersion("0.1.1"), | ||
| extensionVersion("0.2.0"), | ||
| extensionVersion(), // Explicitly test that this doesn't break on bad data |
elvisun
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed that ext:install was not working correctly for stripe/firestore-stripe-payments, because there was a badly formed extension in our backend that did not have a version number. I'm gonna investigate that, but figured I should also make this code less brittle.