functions:delete fails to match function name unless dot notation is used

[twaddington]

Environment info

firebase-tools: 11.16.1
Platform: macOS 12.6.1

Test case

// index.ts
export * as foo from "./providers/foo.js";

// foo.ts
export const bar = functions.pubsub
  .schedule("every day 09:00")
  .onRun(async () => {
    console.log("Hello Firebase");
    return null;
  });

Steps to reproduce

// Fails with error
$ firebase functions:delete foo-bar
Error: The specified filters do not match any existing functions in project.

// Works as expected
$ firebase functions:delete foo.bar
...

// Deploy works the same with either wording
$ firebase deploy --only functions:foo-bar
$ firebase deploy --only functions:foo.bar

Expected behavior

The command firebase functions:delete foo-bar should succeed since that's how the function name appears when listed via firebase functions:list.

Actual behavior

The command firebase functions:delete foo-bar fails with an error.

[twaddington]

From poking around the source it looks like the problem is here:

firebase-tools/src/commands/functions-delete.ts

Lines 36 to 39 in 9b4c233

	const context: args.Context = {
	projectId: needProjectId(options),
	filters: filters.map((f) => ({ idChunks: f.split(".") })),
	};

The deployment command uses a different parsing function here:

firebase-tools/src/deploy/functions/functionsDeployHelper.ts

Lines 59 to 81 in 9b4c233

	export function parseFunctionSelector(selector: string): EndpointFilter[] {
	const fragments = selector.split(":");
	if (fragments.length < 2) {
	// This is a plain selector w/o codebase prefix (e.g. "abc" not "abc:efg") .
	// This could mean 2 things:
	//
	// 1. Only the codebase selector (i.e. "abc" refers to a codebase).
	// 2. Id filter for the DEFAULT codebase (i.e. "abc" refers to a function id in the default codebase).
	//
	// We decide here to create filter for both conditions. This sounds sloppy, but it's only troublesome if there is
	// conflict between a codebase name as function id in the default codebase.
	return [
	{ codebase: fragments[0] },
	{ codebase: DEFAULT_CODEBASE, idChunks: fragments[0].split(/[-.]/) },
	];
	}
	return [
	{
	codebase: fragments[0],
	idChunks: fragments[1].split(/[-.]/),
	},
	];
	}