Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage integration tests #5287

Merged
merged 21 commits into from Dec 5, 2022
Merged

Conversation

Yuangwang
Copy link
Contributor

@Yuangwang Yuangwang commented Dec 1, 2022

Description

Fixed Storage integration tests by updating the puppeteer version, the old one was timing out the tests. Also reenabling the tests on github since they now pass.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Base: 56.27% // Head: 56.28% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fb75b70) compared to base (e1872a4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5287   +/-   ##
=======================================
  Coverage   56.27%   56.28%           
=======================================
  Files         309      309           
  Lines       20830    20830           
  Branches     4229     4229           
=======================================
+ Hits        11723    11725    +2     
+ Misses       8095     8093    -2     
  Partials     1012     1012           
Impacted Files Coverage Δ
src/emulator/auth/state.ts 85.43% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Yuangwang Yuangwang merged commit 1ebb9f8 into master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants