Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug using --only filter to disable no-op deploy fails deploy because function source isn't uploaded #5280

Merged
merged 4 commits into from Dec 1, 2022
Merged

Fix bug using --only filter to disable no-op deploy fails deploy because function source isn't uploaded #5280

merged 4 commits into from Dec 1, 2022

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Nov 30, 2022

Fixes #5270

@taeold taeold marked this pull request as ready for review November 30, 2022 22:07
TheIronDev
TheIronDev approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@TheIronDev TheIronDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@taeold taeold enabled auto-merge (squash) December 1, 2022 18:02
@taeold taeold merged commit d59f265 into master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheIronDev TheIronDev TheIronDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function Deploy - Precondition failed. Cannot update a GCF function without sourceUrl
2 participants
@taeold @TheIronDev