Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy project .npmrc to function dist #5235

Merged
merged 2 commits into from Dec 16, 2022
Merged

Conversation

cjsewell
Copy link
Contributor

To support private repositories and custom npm configs, copy the projects .npmrc file to the functions dist dir before deploying

Description

Scenarios Tested

Sample Commands

src/frameworks/index.ts Outdated Show resolved Hide resolved
src/frameworks/index.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Base: 56.42% // Head: 56.41% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5cbe303) compared to base (d073b09).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5235      +/-   ##
==========================================
- Coverage   56.42%   56.41%   -0.01%     
==========================================
  Files         315      315              
  Lines       21148    21150       +2     
  Branches     4287     4288       +1     
==========================================
  Hits        11932    11932              
- Misses       8191     8193       +2     
  Partials     1025     1025              
Impacted Files Coverage Δ
src/frameworks/index.ts 16.01% <0.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Two nits, happy to merge once addressed

src/frameworks/index.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
To support private repositories and custom npm configs, copy the projects .npmrc file to the functions dist dir before deploying
@cjsewell
Copy link
Contributor Author

No worries, should be all good now

@jamesdaniels jamesdaniels enabled auto-merge (squash) December 16, 2022 01:36
@jamesdaniels jamesdaniels merged commit 699c2a0 into firebase:master Dec 16, 2022
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants