Fix storage admin sdk content type #5229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyjhuang
approved these changes
Nov 10, 2022
| @@ -251,6 +251,26 @@ describe("GCS endpoint conformance tests", () => { | |||
| expect(returnedMetadata.contentType).to.equal(customMetadata.contentType); | |||
| expect(returnedMetadata.contentDisposition).to.equal(customMetadata.contentDisposition); | |||
| }); | |||
|
|
|||
| it("should upload content type properly from x-upload-content-type headers", async () => { | |||
There was a problem hiding this comment.
can you add a test for the media upload protocol above as well?
src/emulator/storage/upload.ts
Outdated
| @@ -44,7 +44,7 @@ export type MediaUploadRequest = { | |||
| export type MultipartUploadRequest = { | |||
| bucketId: string; | |||
| objectId: string; | |||
| metadataRaw: string; | |||
| metadataRaw: object; | |||
There was a problem hiding this comment.
small nit: can you rename this metadata if we're passing in the object
Codecov ReportBase: 56.27% // Head: 56.27% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5229 +/- ##
=======================================
Coverage 56.27% 56.27%
=======================================
Files 309 309
Lines 20813 20815 +2
Branches 4223 4223
=======================================
+ Hits 11712 11714 +2
- Misses 8088 8089 +1
+ Partials 1013 1012 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
abhis3
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the content type admin sdk issues mentioned here #4982
Scenarios Tested
Tested via nodejs admin sdk and python gcs sdk. Also added new tests for this specific issue