Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where disabling background triggers did nothing. #5221

Merged
merged 7 commits into from Nov 16, 2022

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Nov 6, 2022

Fixes #5026

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Base: 56.25% // Head: 56.25% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d020bc1) compared to base (98e23ed).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5221   +/-   ##
=======================================
  Coverage   56.25%   56.25%           
=======================================
  Files         308      308           
  Lines       20814    20817    +3     
  Branches     4225     4226    +1     
=======================================
+ Hits        11708    11710    +2     
- Misses       8094     8095    +1     
  Partials     1012     1012           
Impacted Files Coverage Δ
src/emulator/functionsEmulator.ts 7.10% <0.00%> (-0.04%) ⬇️
src/emulator/auth/state.ts 85.43% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@taeold taeold force-pushed the dl-cf3-emu-disable-triggers branch from 3077a39 to d020bc1 Compare November 7, 2022 00:38
@taeold taeold marked this pull request as ready for review November 7, 2022 13:57
@taeold taeold enabled auto-merge (squash) November 14, 2022 19:55
@taeold taeold merged commit 2354100 into master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling background function triggers no longer has an effect in 11.10.0
4 participants