Handle Next.js rewrites/redirects/headers #5212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdaniels
reviewed
Nov 4, 2022
jamesdaniels
reviewed
Nov 4, 2022
jamesdaniels
reviewed
Nov 7, 2022
also, clean escaped chars from supported `sources`
jamesdaniels
requested changes
Nov 15, 2022
|
Marking as ready for review @leoortizz. If you could add a changelog and tests that would be great. |
`replaceAll` is not supported by Node.js 14
Codecov ReportBase: 56.29% // Head: 56.24% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5212 +/- ##
==========================================
- Coverage 56.29% 56.24% -0.05%
==========================================
Files 309 311 +2
Lines 20828 20887 +59
Branches 4228 4246 +18
==========================================
+ Hits 11725 11748 +23
- Misses 8091 8126 +35
- Partials 1012 1013 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
leoortizz
changed the title
jamesdaniels
requested changes
Nov 16, 2022
leoortizz
requested review from
jamesdaniels and
TheIronDev
and removed request for
jamesdaniels and
TheIronDev
jamesdaniels
reviewed
Dec 8, 2022
jamesdaniels
reviewed
Dec 8, 2022
jamesdaniels
approved these changes
Dec 8, 2022
jamesdaniels
approved these changes
Dec 9, 2022
jamesdaniels
added a commit
that referenced
this pull request
Dec 9, 2022
* Handle Next.js rewrites/redirects/headers incompatible with `firebase.json` in Cloud Functions * Filter out Next.js prerendered routes that matches rewrites/redirects/headers rules from SSG content directory
|
merged in #5316, thanks @leoortizz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
firebase.jsonin Cloud FunctionsScenarios Tested
Sample Commands