Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for object list using certain Admin SDKs #5209

Merged
merged 4 commits into from Nov 3, 2022
Merged

Conversation

abhis3
Copy link
Contributor

@abhis3 abhis3 commented Nov 3, 2022

Description

Add support for object list using certain Admin SDKs. Issue was surfaced in #5208

Scenarios Tested

Tested locally with modified emulator code using a sample GO app and the Admin SDK for GO

Sample Commands

Test Run: npm run test:storage-emulator-integration

@abhis3 abhis3 enabled auto-merge (squash) November 3, 2022 20:42
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Base: 56.23% // Head: 56.24% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5abacd7) compared to base (b02065f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5209   +/-   ##
=======================================
  Coverage   56.23%   56.24%           
=======================================
  Files         308      308           
  Lines       20797    20797           
  Branches     4221     4221           
=======================================
+ Hits        11695    11697    +2     
+ Misses       8091     8090    -1     
+ Partials     1011     1010    -1     
Impacted Files Coverage Δ
src/emulator/storage/apis/gcloud.ts 5.40% <0.00%> (ø)
src/emulator/auth/state.ts 85.43% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants