Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pubsub version/md5/byte size. #5205

Merged
merged 5 commits into from Nov 9, 2022
Merged

Conversation

christhompsongoogle
Copy link
Contributor

Update pubsub version/md5/byte size.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Base: 56.27% // Head: 56.27% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (32d6c17) compared to base (577bd7e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5205   +/-   ##
=======================================
  Coverage   56.27%   56.27%           
=======================================
  Files         309      309           
  Lines       20810    20811    +1     
  Branches     4222     4222           
=======================================
+ Hits        11710    11712    +2     
+ Misses       8088     8087    -1     
  Partials     1012     1012           
Impacted Files Coverage Δ
src/emulator/download.ts 18.46% <0.00%> (-0.29%) ⬇️
src/emulator/downloadableEmulators.ts 23.88% <ø> (ø)
src/emulator/auth/state.ts 85.43% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changlog please

@christhompsongoogle christhompsongoogle enabled auto-merge (squash) November 9, 2022 01:25
@christhompsongoogle christhompsongoogle merged commit be10d72 into master Nov 9, 2022
@christhompsongoogle christhompsongoogle linked an issue Nov 9, 2022 that may be closed by this pull request
@fixl
Copy link

fixl commented Nov 16, 2022

What is new in 0.7.1?

Does anybody know if https://issuetracker.google.com/issues/219992967?pli=1 has been addressed?

@christhompsongoogle
Copy link
Contributor Author

Hi fixl, this is a repackage of the cloud pubsub emulator v0.7.1. We don't add any changes on top of it to incorporate it in the emulator suite. In that case I expect the issue to still be outstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emulators are outdated
4 participants