Add int tests for test lab, remote config, and fireperf #5200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 56.27% // Head: 56.27% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #5200 +/- ##
=======================================
Coverage 56.27% 56.27%
=======================================
Files 309 309
Lines 20820 20820
Branches 4224 4224
=======================================
Hits 11716 11716
Misses 8092 8092
Partials 1012 1012 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
colerogers
force-pushed
the
colerogers.add-int-tests-remoteconfig-testlab-fireperf
branch
from
2234dd4
to
eac3e92
Compare
…tests-remoteconfig-testlab-fireperf
…tests-remoteconfig-testlab-fireperf
…emoteconfig-testlab-fireperf
…tests-remoteconfig-testlab-fireperf
|
Passing workflow run on this branch - https://github.com/firebase/firebase-tools/actions/runs/3517527484 |
taeold
reviewed
Nov 22, 2022
package.json
Outdated
| @@ -93,6 +93,7 @@ | |||
| ] | |||
| }, | |||
| "dependencies": { | |||
| "@firebase/logger": "^0.3.4", | |||
There was a problem hiding this comment.
Hmm this is adding new dep to the CLI. Is this intentional or should this be a dev dep?
taeold
approved these changes
Nov 23, 2022
TheIronDev
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preserveExternalChangesto tests