New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix predeploy hooks not running for framework deploy with predeploy hook #5199
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportBase: 56.27% // Head: 56.27% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #5199 +/- ##
=======================================
Coverage 56.27% 56.27%
=======================================
Files 309 309
Lines 20820 20820
Branches 4224 4225 +1
=======================================
Hits 11716 11716
Misses 8092 8092
Partials 1012 1012
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
LGTM. Unrelated to this PR, lifecycleHooks.ts needs tests. |
Merged in #5288, thanks for the fix @freakness |
Description
Fixes: #5159
Scenarios Tested
This fixes deploying a next.js (or other framework) using predeploy hooks in firebase.json.