Auto-upgrade/downgrade implicit concurrency with CPU changes #5196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheIronDev
approved these changes
Oct 31, 2022
Codecov ReportBase: 56.22% // Head: 56.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5196 +/- ##
=======================================
Coverage 56.22% 56.22%
=======================================
Files 308 308
Lines 20752 20757 +5
Branches 4206 4210 +4
=======================================
+ Hits 11667 11670 +3
Misses 8071 8071
- Partials 1014 1016 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Updated to also upgrade concurrency when it is not specified and CPU grows to support it. |
taeold
approved these changes
Oct 31, 2022
src/deploy/functions/prepare.ts
Outdated
Comment on lines
330
to
331
| // turn off concurrency. We'll not do the opposite and turn on concurrency | ||
| // if there are >1 CPU because this could expose race conditions. They | ||
| // either need to start on concurrency where they've always needed to | ||
| // handle race conditions, or they should explicitly enable. | ||
| // We'll hanndle this in setCpuAndConcurrency |
There was a problem hiding this comment.
This comment seems inaccurate w/ latest implementation. We do upgrade concurrency regardless, ignoring race condition.
inlined
force-pushed
the
inlined.auto-concurrency-downgrade
branch
from
057e4b4
to
f4caad0
Compare
inlined
changed the title
taeold
added a commit
that referenced
this pull request
Nov 2, 2022
Concurrency will aggressively default to 80 per #5196.
taeold
added a commit
that referenced
this pull request
Nov 3, 2022
Concurrency will aggressively default to 80 per #5196.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #1288 if we decide to take it. We can decide to: