Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle gzip compression in Storage Emulator #5185

Merged
merged 17 commits into from Nov 7, 2022
Merged

Conversation

tonyjhuang
Copy link
Contributor

Fixes #4957.

For gzipped file uploads, serve them decompressed by default. For requests with the Accept-Encoding header set to gzip, return them as is.

@tonyjhuang tonyjhuang enabled auto-merge (squash) October 27, 2022 15:51
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@ea2a9ec). Click here to learn what that means.
Patch coverage: 13.51% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5185   +/-   ##
=========================================
  Coverage          ?   56.26%           
=========================================
  Files             ?      309           
  Lines             ?    20792           
  Branches          ?     4218           
=========================================
  Hits              ?    11699           
  Misses            ?     8083           
  Partials          ?     1010           
Impacted Files Coverage Δ
src/emulator/storage/apis/shared.ts 9.67% <9.67%> (ø)
src/emulator/storage/apis/firebase.ts 4.51% <25.00%> (ø)
src/emulator/storage/apis/gcloud.ts 5.44% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tonyjhuang tonyjhuang merged commit 72d23ec into master Nov 7, 2022
@tonyjhuang tonyjhuang deleted the tonyjhuang/gzip branch November 7, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requested files stored in the firebase storage emulator as gzip are always fetched uncompressed
4 participants