New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --disable-triggers
flag to database write commands
#5179
Conversation
Codecov ReportBase: 56.13% // Head: 56.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5179 +/- ##
=======================================
Coverage 56.13% 56.13%
=======================================
Files 308 308
Lines 20737 20738 +1
Branches 4198 4198
=======================================
+ Hits 11640 11641 +1
Misses 8087 8087
Partials 1010 1010
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approvals: ✅ the API doc was approved, ✅ implementation of the API looks great.
I'd ask to wait on a review from your team, but everything else looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after Bryan's feedbacks are addressed
Description
b/233759622
API Proposal: go/fbi-disable-triggers-api
Based on https://github.com/FirebasePrivate/firebase-tools/pull/539
Sample Commands