Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --disable-triggers flag to database write commands #5179

Merged
merged 6 commits into from Oct 26, 2022

Conversation

tohhsinpei
Copy link
Member

@tohhsinpei tohhsinpei commented Oct 26, 2022

Description

b/233759622

API Proposal: go/fbi-disable-triggers-api

Based on https://github.com/FirebasePrivate/firebase-tools/pull/539

Sample Commands

firebase database:push /some/path --data '{"foo": "bar"}' --disable-triggers
firebase database:set /some/path --data '{"foo": "bar"}' --disable-triggers
firebase database:update /some/path --data '{"foo": "bar"}' --disable-triggers
firebase database:remove /some/path --disable-triggers

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Base: 56.13% // Head: 56.13% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bfc6687) compared to base (2b4261e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5179   +/-   ##
=======================================
  Coverage   56.13%   56.13%           
=======================================
  Files         308      308           
  Lines       20737    20738    +1     
  Branches     4198     4198           
=======================================
+ Hits        11640    11641    +1     
  Misses       8087     8087           
  Partials     1010     1010           
Impacted Files Coverage Δ
src/database/remove.ts 92.30% <100.00%> (ø)
src/database/removeRemote.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@bkendall bkendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approvals: ✅ the API doc was approved, ✅ implementation of the API looks great.

I'd ask to wait on a review from your team, but everything else looks good!

src/database/remove.ts Outdated Show resolved Hide resolved
src/database/removeRemote.ts Outdated Show resolved Hide resolved
src/test/database/removeRemote.spec.ts Show resolved Hide resolved
Copy link
Contributor

@fredzqm fredzqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after Bryan's feedbacks are addressed

@tohhsinpei tohhsinpei enabled auto-merge (squash) October 26, 2022 17:52
@tohhsinpei tohhsinpei merged commit 793253f into master Oct 26, 2022
@tohhsinpei tohhsinpei deleted the hsinpei/disable-triggers branch October 26, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants