Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel requests in the functions emulator #5149

Merged
merged 9 commits into from Nov 1, 2022

Conversation

colerogers
Copy link
Contributor

@colerogers colerogers commented Oct 20, 2022

Addresses #5134 and adds an e2e test for parallel requests

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Base: 56.21% // Head: 56.22% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (52b5d90) compared to base (88fe601).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5149      +/-   ##
==========================================
+ Coverage   56.21%   56.22%   +0.01%     
==========================================
  Files         308      308              
  Lines       20786    20789       +3     
  Branches     4220     4220              
==========================================
+ Hits        11685    11689       +4     
  Misses       8090     8090              
+ Partials     1011     1010       -1     
Impacted Files Coverage Δ
src/emulator/functionsRuntimeWorker.ts 65.03% <60.00%> (+0.03%) ⬆️
src/emulator/auth/state.ts 85.43% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@colerogers colerogers marked this pull request as ready for review October 28, 2022 15:21
Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comment on tests

scripts/integration-helpers/framework.ts Outdated Show resolved Hide resolved
scripts/triggers-end-to-end-tests/triggers/index.js Outdated Show resolved Hide resolved
scripts/triggers-end-to-end-tests/v2/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a changelog entry too?

@colerogers colerogers merged commit 4f63950 into master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants