Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't need no public dir #5142

Merged
merged 3 commits into from Oct 18, 2022
Merged

We don't need no public dir #5142

merged 3 commits into from Oct 18, 2022

Conversation

inlined
Copy link
Member

@inlined inlined commented Oct 18, 2022

Fix next.js deploys w/o a public dir.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Base: 56.16% // Head: 56.15% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (3b818b6) compared to base (31f9b00).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5142      +/-   ##
==========================================
- Coverage   56.16%   56.15%   -0.01%     
==========================================
  Files         308      308              
  Lines       20721    20724       +3     
  Branches     4195     4197       +2     
==========================================
  Hits        11637    11637              
- Misses       8074     8077       +3     
  Partials     1010     1010              
Impacted Files Coverage Δ
src/frameworks/next/index.ts 15.00% <0.00%> (-0.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@inlined inlined changed the base branch from master to next October 18, 2022 01:53
@inlined inlined merged commit 73884ec into next Oct 18, 2022
@inlined inlined deleted the inlined.we-dont-need-no-public branch October 18, 2022 01:55
bkendall added a commit that referenced this pull request Oct 18, 2022
* Make web frameworks public (#5136)

* We don't need no public dir (#5142)

* We don't need no public dir

* Add docs

* Add changelog

Co-authored-by: Thomas Bouldin <inlined@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants