Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating link to docs and massaging some text. #5131

Merged
merged 3 commits into from Nov 8, 2022
Merged

Conversation

egilmorez
Copy link
Contributor

The URL to functions/get-started needed to be updated. Also tweaked some text to line up with docs.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Base: 56.25% // Head: 56.28% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (356e18f) compared to base (98e23ed).
Patch coverage: 12.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5131      +/-   ##
==========================================
+ Coverage   56.25%   56.28%   +0.03%     
==========================================
  Files         308      309       +1     
  Lines       20814    20810       -4     
  Branches     4225     4222       -3     
==========================================
+ Hits        11708    11712       +4     
+ Misses       8094     8086       -8     
  Partials     1012     1012              
Impacted Files Coverage Δ
src/emulator/functionsEmulator.ts 7.12% <0.00%> (-0.02%) ⬇️
src/emulator/storage/apis/shared.ts 9.67% <9.67%> (ø)
src/emulator/storage/apis/firebase.ts 4.51% <25.00%> (+0.25%) ⬆️
src/emulator/storage/apis/gcloud.ts 5.44% <50.00%> (+0.04%) ⬆️
src/emulator/auth/state.ts 85.43% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@bkendall bkendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval. A changelog entry may be nice, but not a blocker.

@egilmorez egilmorez merged commit 577bd7e into master Nov 8, 2022
@egilmorez egilmorez deleted the eg-templateupdate branch November 8, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants