Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firebase Hosting: firebase deploy ignores the -m argument in version 11.14.1 #5107

Closed
guneemwelloeux opened this issue Oct 11, 2022 · 1 comment · Fixed by #5109
Closed

Firebase Hosting: firebase deploy ignores the -m argument in version 11.14.1 #5107

guneemwelloeux opened this issue Oct 11, 2022 · 1 comment · Fixed by #5109
Assignees
@bkendall
Labels
api: hosting

Comments

@guneemwelloeux
Copy link

guneemwelloeux commented Oct 11, 2022 •
edited

In version 11.14.1 of firebase-tools, the firebase deploy command seems to completely ignore the -m argument (description), and the description in empty in the Firebase Hosting dashboard.
Version 11.13.0 was working fine in that regard.

I believe this change to be the offending one, where it seems that the release message was dropped in the new api.createRelease function

3a92daf#diff-7d0f3d70809a7e16334fc0ebd9d0b60757f72a416dd11397b62c37ef41b5ed1fL51
@bkendall bkendall self-assigned this Oct 11, 2022
@bkendall bkendall mentioned this issue Oct 11, 2022
Merged
@bkendall
Copy link
Contributor

You're right. A consequence of a refactor that happened. Will squish the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkendall bkendall

Labels
api: hosting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix missing message on deploy firebase/firebase-tools
2 participants
@bkendall @guneemwelloeux