Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UI listening on mutliple addresses. #5088

Merged
merged 5 commits into from Oct 7, 2022
Merged

Conversation

yuchenshi
Copy link
Member

Description

This makes the Emulator UI listen on multiple addresses (v4 and v6) if possible.

Scenarios Tested

Started the UI, clicked things around.

Sample Commands

@yuchenshi yuchenshi enabled auto-merge (squash) October 7, 2022 22:08
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Base: 56.05% // Head: 56.06% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (cd0f3d5) compared to base (70180c9).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5088   +/-   ##
=======================================
  Coverage   56.05%   56.06%           
=======================================
  Files         307      307           
  Lines       20634    20635    +1     
  Branches     4166     4166           
=======================================
+ Hits        11566    11568    +2     
+ Misses       8067     8066    -1     
  Partials     1001     1001           
Impacted Files Coverage Δ
src/emulator/controller.ts 13.25% <0.00%> (+0.03%) ⬆️
src/emulator/downloadableEmulators.ts 23.30% <ø> (ø)
src/emulator/hub.ts 16.49% <0.00%> (ø)
src/emulator/portUtils.ts 52.10% <ø> (ø)
src/emulator/ui.ts 38.09% <66.66%> (+3.09%) ⬆️
src/emulator/ExpressBasedEmulator.ts 75.51% <100.00%> (+0.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants