New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firebase-tools v11.14.0 does not run predeploy scripts when deploying Hosting from GitHub Actions #5072
Comments
We are facing the same issue our ci cd stopped working since the relaease of 11.14.0 |
We are having the same issue to add priority to this bug. |
Having the same issue on our side too since last night when the new version has been released. |
Ditto! Adding the following command before calling using
|
This also affects my project. If I manually build, it shows an even weirder error on the log that the deployment action failed because it could not list my cloud functions (I'm deploying to hosting) firebase-debug.log
|
Same here. Our CI/CD for deploying to Firebase Hosting stopped working after this release. The error is that it could not list our cloud functions. |
For folks who are seeing this: can you tell me how you've configured your predeploy steps? I'm struggling to reproduce this trivially by adding |
I've tried calling As seen in the screenshot, |
@bkendall I can reproduce this on one of my open source projects. Hope it helps! |
@dtinth does it fail to run the predeploy script if you run the same command ( |
@johnnyasantoss the permissions issue you see is #5071 and has a fix on the way, fwiw. 🙂 I'm just really stumped on trying to get this issue happening locally. |
@bkendall No. I mean, yes, it fails to run. It does not run the predeploy script.
|
Okay, I'm thinking out loud a bit. The |
Here's a question: if you have a way to do it, does it work with just edit: I don't think this is the difference. |
@bkendall The easiest way to reproduce the error would be to follow the same steps done by GitHub Actions (i.e. cloning the same repo, checking out the same commit, running the same commands but with a different Firebase project). From my further testing, it seems that Upon further digging, it seems that these PRs are related to the introduction of this bug: With the above changes, A validation stop checks if the directory specified in |
@dtinth that is different than what I thought that issue was, and is good insight. I think I know how to address that! |
it's a really, really hacky fix, but if you I have the code in front of me now and am furiously making changes |
@johnnyasantoss it was released in v11.14.1: https://github.com/firebase/firebase-tools/releases/tag/v11.14.1 |
[REQUIRED] Environment info
firebase-tools: 11.14.0
Platform: Ubuntu
[REQUIRED] Test case
N/A right now, maybe someone can help add a test case if they are experiencing the same issue. However, a log is available below, and it is confirmed that this only happens in v11.14.0.I can reproduce this in one of my open-source projects, WebMIDICon:
[REQUIRED] Steps to reproduce
We use https://github.com/FirebaseExtended/action-hosting-deploy to deploy. The command is this:
This results in this command invoked:
npx firebase-tools hosting:channel:deploy pr285-octopus-perf --expires 30d --project $FIREBASE_PROJECT_ID --json
[REQUIRED] Expected behavior
firebase deploy
should trigger the "predeploy" steps configured in "firebase.json"[REQUIRED] Actual behavior
firebase deploy
did not run the script at all.See image below for log comparison (before/after):
Workaround
Downgrade
firebase-tools
to 11.13.0 before running.The text was updated successfully, but these errors were encountered: