Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass singleProjectMode config down to the database emulator and bump the version to 4.10.0. #5068

Merged
merged 8 commits into from Oct 7, 2022

Conversation

christhompsongoogle
Copy link
Contributor

@christhompsongoogle christhompsongoogle commented Oct 6, 2022

Pass singleProjectMode config down to the database emulator and bump the version to 4.10.0.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 55.75% // Head: 55.74% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (415c4f7) compared to base (9f86b0f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5068      +/-   ##
==========================================
- Coverage   55.75%   55.74%   -0.01%     
==========================================
  Files         305      305              
  Lines       20529    20530       +1     
  Branches     4145     4146       +1     
==========================================
  Hits        11445    11445              
- Misses       8101     8102       +1     
  Partials      983      983              
Impacted Files Coverage Δ
src/emulator/controller.ts 12.76% <0.00%> (-0.04%) ⬇️
src/emulator/databaseEmulator.ts 15.05% <ø> (ø)
src/emulator/downloadableEmulators.ts 23.30% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@christhompsongoogle christhompsongoogle changed the title Pass singleProjectMode config down to auth and database emulators. Pass singleProjectMode config down to the database emulator and bump the version to 4.10.0. Oct 6, 2022
Copy link
Contributor

@fredzqm fredzqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@christhompsongoogle christhompsongoogle enabled auto-merge (squash) October 7, 2022 00:00
@fredzqm fredzqm removed their assignment Oct 7, 2022
@christhompsongoogle christhompsongoogle merged commit e08c6d4 into master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants