[Function-NoOp] Enable Skipping NoOp Deploys by Default #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 55.89% // Head: 55.88% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5032 +/- ##
==========================================
- Coverage 55.89% 55.88% -0.01%
==========================================
Files 305 305
Lines 20351 20347 -4
Branches 4100 4099 -1
==========================================
- Hits 11375 11371 -4
- Misses 8021 8022 +1
+ Partials 955 954 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Add a CHANGELOG entry, please. |
bkendall
approved these changes
Sep 29, 2022
taeold
approved these changes
Sep 29, 2022
TheIronDev
force-pushed
the
tystark.noop-functions-deploy-default
branch
from
00af952
to
cd91d4b
Compare
christhompsongoogle
pushed a commit
that referenced
this pull request
Sep 30, 2022
## Description This commit flips the "skip no-op deploys" flag to default to true. When enabled, firebase deploy will compare the last deployed instances of a function with the current copy and, if they are the same, will skip uploading and deploying the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit flips the "skip no-op deploys" flag to default to
true.When enabled,
firebase deploywill compare the last deployed instances of a function with the current copy and, if they are the same, will skip uploading and deploying the function.