Adds test lab triggers to firebase deploy #5011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colerogers
force-pushed
the
colerogers.test-lab
branch
from
8ebc4a3
to
ae264c6
Compare
taeold
approved these changes
Sep 29, 2022
| endpoint.eventTrigger.region = "global"; | ||
| } | ||
| if (endpoint.eventTrigger.region !== "global") { | ||
| throw new FirebaseError("A test lab trigger must specify 'global' trigger location"); |
There was a problem hiding this comment.
nit* Does Test Lab team have a product name preference? e.g. test lab vs testlab vs TestLab vs Test Lab?
There was a problem hiding this comment.
All sites/docs/team pages show Test Lab, but in the CLI we tend to keep everything lowercase. I'll change for this service and maybe we can revisit the other implemented services later
colerogers
force-pushed
the
colerogers.test-lab
branch
from
ae264c6
to
3de3af0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds v2 test lab triggers to
firebase deploy