Single project mode #4890
Single project mode #4890
Conversation
Codecov ReportBase: 57.29% // Head: 57.27% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4890 +/- ##
==========================================
- Coverage 57.29% 57.27% -0.03%
==========================================
Files 288 288
Lines 19039 19046 +7
Branches 3769 3773 +4
==========================================
Hits 10908 10908
- Misses 7237 7244 +7
Partials 894 894
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Reverted |
src/init/features/emulators.ts
Outdated
| @@ -100,6 +100,11 @@ export async function doSetup(setup: any, config: any) { | |||
| ]); | |||
| } | |||
|
|
|||
| // Set the default behavior to be single project mode. | |||
| if (setup.config.emulators.singleProjectMode !== undefined) { | |||
There was a problem hiding this comment.
If singleProjectMode in firebase.json is set to false, this condition means that singleProjectMode will be enabled. I'm sure that's not the intention.
Do you mean to just check if it's truthy?
| if (setup.config.emulators.singleProjectMode !== undefined) { | |
| if (setup.config.emulators.singleProjectMode) { |
There was a problem hiding this comment.
Fixed, nice find. After some testing this was backwards. The intention here is to set if it it doesn't exist, create the config, otherwise leave it as the user set it. The default should be true, but the current behavior is false.
christhompsongoogle
force-pushed
the
singleProjectMode
branch
from
5ecb346
to
4941195
Compare
christhompsongoogle
force-pushed
the
singleProjectMode
branch
from
4941195
to
cb3eefb
Compare
|
I am getting megabytes and megabytes of log entries with the message:
To the point that it is impacting the performance of the build machine. Anyway, following the message, I have tried setting the mentioned flag "single_project_mode" to false in firebase.json, but the flag seems to be rejected by the emulator. I haven't yet tested it with that spelling, I will try to report back when I do. |
|
@kovan please open a new issue with the relevant information. thanks! |
Add a singleProjectMode flag to the firebase config which defaults to true (on init and if missing when read).
Pass the flag to firestore in the form of a warning for now.
Requires the latest version of firestore to be cut including CL/466521585
Tested: Manual testing for configuration and firestore emulator.