migrate management API calls to apiv2 #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
reviewed
May 19, 2022
src/test/management/apps.spec.ts
Outdated
| @@ -61,21 +64,22 @@ function generateWebAppList(counts: number): WebAppMetadata[] { | |||
| })); | |||
| } | |||
|
|
|||
| describe("App management", () => { | |||
| describe.only("App management", () => { | |||
joehan
reviewed
May 19, 2022
joehan
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates all the API calls in the management folder to apiv2. Done by using
nockin the tests (which validates the calls being made) and then replacing the actual calls, so I know the requests are the same.Scenarios Tested